Refactor GHA workflows#46
Conversation
|
On second thought, will not do separate jobs, because too much leg work would be required to carry the artifacts between jobs since we rely heavily on docker compose (only hacks can be used with |
|
Looks great, thank you for separating the jobs! Job tree:
|
in this case, i'll go ahead and implement the tree above which could be the foundation to effectively parallelize the jobs with minimum redundancy. |
|
@ktamas77 Out of draft status. We will likely need to override the Check Requirement since the workflow filename changed or add the old check into this branch to trick the Check Requirement into passing. I believe this check is hanging because GH is presently requiring a check that does not exist in this branch. |
| personal_token: ${{ secrets.DACOCOBOT_PAT }} | ||
| publish_dir: ./openapi | ||
| publish_branch: docs | ||
| run: docker compose run api yarn lint-prettier No newline at end of file |
There was a problem hiding this comment.
[low-prio non-blocking nit-pick]
| run: docker compose run api yarn lint-prettier | |
| run: docker compose run api yarn lint-prettier | |
Lint
Deploy
envto global scope instead of job scope (DRY)Notes
Created separate jobs for deploy, this is so that GH Pages deploy and Packages Deploy can occur in parallel.Not worth itTodo
Carry artifacts between jobs inDecided against separate jobsdeploy